fix(vercel): Updates Node v18 notice #14491
Conversation
🦋 Changeset detectedLatest commit: 02c3eab The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
jacobdalamb
changed the title
jacobdalamb
changed the title
.changeset/twelve-cats-relax.md
Outdated
| '@astrojs/vercel': major | ||
| --- | ||
|
|
||
| Removes deprecation notice for Node.js 18 as Vercel no longer supports it. |
There was a problem hiding this comment.
Just checking: does this PR only remove the deprecation notice, or does it actually remove support entirely? There's a difference! 😅
Here's an example from the v3 upgrade guide of how we've typically documented removing support for a Node version. Do you want to take a shot at writing something like this @jacobdalamb ? For a major update, and breaking change, we also always include a #### What should I do? section with specific guidance.
Then, tag me in and I'll take a look at it!
There was a problem hiding this comment.
Yes, it only removes the deprecation notice.
Any user still on Node.js v18 or older will get a warning and Astro will default to using Node.js v22 (default) as the runtime anyway.
|
Also noting, I checked what we say in docs about the minimum/supported Node versions for the Vercel adapter, and I think we should be good and no docs changes are needed. |
jacobdalamb
changed the title
Eliminates the 'removal' date property from deprecated Node.js version support and related formatting logic. This simplifies the SUPPORTED_NODE_VERSIONS structure and warning messages.
3 participants
Changes
Updates Node v18 'retiring' notice to 'deprecated' for Vercel adapter.
Removes
removeDatefrom 'deprecated' notice text.Testing
n/a
Docs
n/a